OpenLP 3.1.1 "Beaming Bartimaeus" has been released!

jlgtx

I've been using 2.4.6 on an M1 MacBook Pro, and holding off on updating due to the various Apple Silicon issues, VLC, etc. Figured I'd give 3.1.1 a shot, so I downloaded, installed, ran the necessary xattr commands, and fired it up. It asked about doing a backup, which I did, and then it gave me the OpenLP logo and a spinning beachball. It's been hung like that for over ten minutes. The openlp.log shows this:

2024-03-11 14:03:14,385 MainThread openlp.plugins.songs.lib.importer                       ERROR    Error importing SongsOfFellowshipImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 61, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/songsoffellowship.py", line 33, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ModuleNotFoundError: No module named 'uno'
2024-03-11 14:03:14,386 MainThread openlp.plugins.songs.lib.importer                       ERROR    Error importing OooImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 67, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ModuleNotFoundError: No module named 'uno'
2024-03-11 14:03:15,263 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  {"parts": ["songs", "audio", "335", "How Firm A Foundation (Foundation).txt"], "json_meta": {"class": "Path", "version": 1}} does not exists, so no sha256 hash added.
2024-03-11 14:03:15,264 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  {"parts": ["songs", "audio", "862", "Cuando las bases de este mundo.pdf"], "json_meta": {"class": "Path", "version": 1}} does not exists, so no sha256 hash added.
2024-03-11 14:03:15,369 MainThread openlp.core.db.upgrades                                 ERROR    Could not run database upgrade script "upgrade_3", upgrade process has been halted.
Traceback (most recent call last):
  File "sqlalchemy/engine/base.py", line 1905, in _execute_context
  File "sqlalchemy/engine/default.py", line 736, in do_execute
sqlite3.OperationalError: no such column: image_filenames.filename

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "openlp/core/db/upgrades.py", line 95, in upgrade_db
  File "openlp/plugins/images/lib/upgrade.py", line 102, in upgrade_3
  File "sqlalchemy/engine/base.py", line 1385, in execute
  File "sqlalchemy/sql/elements.py", line 334, in _execute_on_connection
  File "sqlalchemy/engine/base.py", line 1577, in _execute_clauseelement
  File "sqlalchemy/engine/base.py", line 1948, in _execute_context
  File "sqlalchemy/engine/base.py", line 2129, in _handle_dbapi_exception
  File "sqlalchemy/util/compat.py", line 211, in raise_
  File "sqlalchemy/engine/base.py", line 1905, in _execute_context
  File "sqlalchemy/engine/default.py", line 736, in do_execute
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: image_filenames.filename
[SQL: SELECT image_filenames.id, image_filenames.group_id, image_filenames.filename, image_filenames.file_path
FROM image_filenames]
(Background on this error at: https://sqlalche.me/e/14/e3q8)

raoul

jlgtx I've seen this issue before, but I thought we had fixed it. There's an issue with some older song databases where they mark themselves at a later version than they actually are. Can you upload your songs.sqlite file to Dropbox, or similar, and then send an e-mail to bugs31 - at - openlp.org with the link? I can fix your DB.

jlgtx

For comparison, once I revert to 2.4.6, it runs fine, but I see this in openlp.log:

2024-03-11 14:27:10,846 openlp.core.utils.actions                               WARNING  Shortcut "Ctrl+?" is removed from "onlineHelpItem" because another action already uses this shortcut.
2024-03-11 14:27:11,181 openlp.plugins.songs.lib.importer                       ERROR    Error importing SongsOfFellowshipImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 56, in <module>
  File "/Users/raoul/Projects/PyInstaller-3.2/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
  File "openlp/plugins/songs/lib/importers/songsoffellowship.py", line 34, in <module>
  File "/Users/raoul/Projects/PyInstaller-3.2/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ImportError: No module named 'uno'
2024-03-11 14:27:11,181 openlp.plugins.songs.lib.importer                       ERROR    Error importing OooImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 62, in <module>
  File "/Users/raoul/Projects/PyInstaller-3.2/PyInstaller/loader/pyimod03_importers.py", line 389, in load_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ImportError: No module named 'uno'

raoul

jlgtx Those "errors" about "uno" are really just warnings. You can safely ignore them.

HansH

OpenLP 3.1.1. bevat nog steeds Engelse tekst door de NL tekst heen.

witterholt

HansH Welk besturingssysteem gebruik je en kun je voorbeelden geven?

Ik heb zelf o.a. dit voorbeeld gevonden:

Voor wat betreft de knoppen; deze vertalingen zitten in het project van het onderliggende pakket dat we gebruiken voor sommige componenten in de gebruikersinterface.
De Nederlandse vertalingen missen echter in de MSI installer voor Windows. We gaan ervoor zorgen dat die met de volgende versie meegeleverd worden.

Missende vertaling van de sectiekoppen "Authors", "Topics" en "Songbooks" is een bug welke in de volgende versie opgelost zal zijn.

As for the buttons; these translations are included in the project of the underlying package that we use for some components in the user interface.
However, the Dutch translations are missing in the MSI installer for Windows. We're going to make sure that these come along for Windows as well.

Missing translation of the section headings "Authors", "Topics" and "Songbooks" is a bug that will be fixed in the next release.

jlgtx

Uploaded & emailed my songs.sqlite database as requested. Out of curiosity, if I open the file using a tool like "DB Browser for SQLite" is there a way to repair it myself? I support several different places that use OpenLP, and if I run into this issue again, it would be convenient to avoid the need for back & forth.

raoul

jlgtx I'll take a look at your DB and then I'll let you know. Hopefully there should be an easy way to sort that out.

raoul

jlgtx apparently our incoming e-mails were failing silently the last few days. I just fixed it, and confirmed it's working, can you send your DB again please?

Thanks!

raoul

jlgtx I just tested this out on your database.

Make sure OpenLP is closed
Open the songs.sqlite file with DB Browser for SQLite
Go to the "Browse Data" tab
Select the "metadata" table from the dropdown
Change the "version" number to 1
Click the "Write Changes" button
Run OpenLP, and it should fix your database.

I'll add an issue to make OpenLP handle this internally.

HansH

witterholt Hierbij een screenshot OpenLP 3.1.1.1500 met Windows 11 home 23H2

joe

Does anyone else have the problem that the settings dialog is broader than the screen?
I cannot get it smaller than about 2175px wide. Is that a bug or a feature? I occurrs on Openlp 3.0.2 AND on OpenLP 3.1.1 (installed via flatpak)

I am using Ubuntu 23.10 with X11; my external screen is big enough to fit the settings dialog, but when I go live, I use the screen of the notebook (1920x1080), and there the [OK] button is off screen.

raoul

joe My monitors are all 1920x1080, and I don't have this problem. Can you show a screenshot?

jlgtx

raoul tried that just now. Changed the version to 1, then opened 3.1.1. Still getting the beachball, but the error log is a little different.

2024-03-15 12:47:17,701 MainThread openlp.plugins.songs.lib.importer                       ERROR    Error importing SongsOfFellowshipImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 61, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/songsoffellowship.py", line 33, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ModuleNotFoundError: No module named 'uno'
2024-03-15 12:47:17,702 MainThread openlp.plugins.songs.lib.importer                       ERROR    Error importing OooImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 67, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ModuleNotFoundError: No module named 'uno'
2024-03-15 12:47:17,828 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  Skipping upgrade_2 step of upgrading the song db
2024-03-15 12:47:17,829 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  Skipping upgrade_3 step of upgrading the song db
2024-03-15 12:47:17,846 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  {"parts": ["songs", "audio", "335", "How Firm A Foundation (Foundation).txt"], "json_meta": {"class": "Path", "version": 1}} does not exists, so no sha256 hash added.
2024-03-15 12:47:17,846 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  {"parts": ["songs", "audio", "862", "Cuando las bases de este mundo.pdf"], "json_meta": {"class": "Path", "version": 1}} does not exists, so no sha256 hash added.
2024-03-15 12:47:17,948 MainThread openlp.core.db.upgrades                                 ERROR    Could not run database upgrade script "upgrade_3", upgrade process has been halted.
Traceback (most recent call last):
  File "sqlalchemy/engine/base.py", line 1905, in _execute_context
  File "sqlalchemy/engine/default.py", line 736, in do_execute
sqlite3.OperationalError: no such column: image_filenames.filename

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "openlp/core/db/upgrades.py", line 95, in upgrade_db
  File "openlp/plugins/images/lib/upgrade.py", line 102, in upgrade_3
  File "sqlalchemy/engine/base.py", line 1385, in execute
  File "sqlalchemy/sql/elements.py", line 334, in _execute_on_connection
  File "sqlalchemy/engine/base.py", line 1577, in _execute_clauseelement
  File "sqlalchemy/engine/base.py", line 1948, in _execute_context
  File "sqlalchemy/engine/base.py", line 2129, in _handle_dbapi_exception
  File "sqlalchemy/util/compat.py", line 211, in raise_
  File "sqlalchemy/engine/base.py", line 1905, in _execute_context
  File "sqlalchemy/engine/default.py", line 736, in do_execute
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: image_filenames.filename
[SQL: SELECT image_filenames.id, image_filenames.group_id, image_filenames.filename, image_filenames.file_path
FROM image_filenames]
(Background on this error at: https://sqlalche.me/e/14/e3q8)

joe

raoul I thougt it could be good to make a new thread out of that "dialog-too-wide-problem", so here it is, screenshots included: Settings dialg too wide

raoul

jlgtx Are you sure you clicked the "Write Changes" button? It doesn't look like you actually wrote the changes to disk. Either that or perhaps you're opening the wrong file?

(updated my previous post to include a screenshot of the button)

jlgtx

raoul Definitely set & saved to 1. Close the file, reopen, it's still 1. Open 3.1.1, spinning beachball, give it awhile, force quite. Open the file, version is now 8. Change & save it to 1, open 3.1.1 again. Spinning beachball, and log says:

2024-03-15 13:00:44,410 MainThread openlp.plugins.songs.lib.importer                       ERROR    Error importing SongsOfFellowshipImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 61, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/songsoffellowship.py", line 33, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ModuleNotFoundError: No module named 'uno'
2024-03-15 13:00:44,410 MainThread openlp.plugins.songs.lib.importer                       ERROR    Error importing OooImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 67, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ModuleNotFoundError: No module named 'uno'
2024-03-15 13:00:44,501 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  Skipping upgrade_2 step of upgrading the song db
2024-03-15 13:00:44,502 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  Skipping upgrade_3 step of upgrading the song db

(I also notice that, if I restore the original openlp folder, change the version in songs.sqlite to 1, and open OpenLP 2.4.6, it changes the version to 5 every time.)

jlgtx

I eliminated the two spurious entries in the Audio table, and that got rid of those two errors, but opening 3.1.1 still beachballs.

2024-03-15 13:15:19,684 MainThread openlp.plugins.songs.lib.importer                       ERROR    Error importing SongsOfFellowshipImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 61, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/songsoffellowship.py", line 33, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ModuleNotFoundError: No module named 'uno'
2024-03-15 13:15:19,685 MainThread openlp.plugins.songs.lib.importer                       ERROR    Error importing OooImport
Traceback (most recent call last):
  File "openlp/plugins/songs/lib/importer.py", line 67, in <module>
  File "PyInstaller/loader/pyimod02_importers.py", line 419, in exec_module
  File "openlp/plugins/songs/lib/importers/openoffice.py", line 39, in <module>
ModuleNotFoundError: No module named 'uno'
2024-03-15 13:15:19,799 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  Skipping upgrade_2 step of upgrading the song db
2024-03-15 13:15:19,802 MainThread openlp.plugins.songs.lib.upgrade                        WARNING  Skipping upgrade_3 step of upgrading the song db
2024-03-15 13:15:19,916 MainThread openlp.core.db.upgrades                                 ERROR    Could not run database upgrade script "upgrade_3", upgrade process has been halted.
Traceback (most recent call last):
  File "sqlalchemy/engine/base.py", line 1905, in _execute_context
  File "sqlalchemy/engine/default.py", line 736, in do_execute
sqlite3.OperationalError: no such column: image_filenames.filename

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "openlp/core/db/upgrades.py", line 95, in upgrade_db
  File "openlp/plugins/images/lib/upgrade.py", line 102, in upgrade_3
  File "sqlalchemy/engine/base.py", line 1385, in execute
  File "sqlalchemy/sql/elements.py", line 334, in _execute_on_connection
  File "sqlalchemy/engine/base.py", line 1577, in _execute_clauseelement
  File "sqlalchemy/engine/base.py", line 1948, in _execute_context
  File "sqlalchemy/engine/base.py", line 2129, in _handle_dbapi_exception
  File "sqlalchemy/util/compat.py", line 211, in raise_
  File "sqlalchemy/engine/base.py", line 1905, in _execute_context
  File "sqlalchemy/engine/default.py", line 736, in do_execute
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: image_filenames.filename
[SQL: SELECT image_filenames.id, image_filenames.group_id, image_filenames.filename, image_filenames.file_path
FROM image_filenames]
(Background on this error at: https://sqlalche.me/e/14/e3q8)

jlgtx

What about the preferences file for 3.1.1, should I delete that prior to retrying the upgrade?

(n/m, tried it, no difference)

raoul

jlgtx First, you can ignore the "uno" error, this is because you are on a Mac. It's not really an error, more of a warning anyway.

Secondly, I see in your first log file that OpenLP seems to have skipped some upgrades, that is correct behaviour. The second log message has the same error as prior (no such column name image_filesnames.filename)

Third, 8 is the correct version number for OpenLP 3.1.1, and 5 is the correct version number for 2.4.6. This is why we set it back to 1, so that we could get OpenLP to retrigger the upgrades, and skip the ones it has already done (as per the warnings about skipping upgrades).

Lastly, the preferences have no effect on what we're looking at here.

Can you create a debug log file for us? I'd like to see where OpenLP is hanging.

jlgtx

Get this, it opens just fine in debug mode. It also opens just fine using the command line with no debug flag. But if I double-click the app in a Finder window, beachball.

Debug log:
https://pastebin.com/raw/X5ZubSMA

Command line response, in case it's helpful:

% /Applications/OpenLP.app/Contents/MacOS/OpenLP -l debug
Logging to: /Users/jon/Library/Application Support/openlp/openlp.log and level 10
2024-03-15 13:40:15.443 OpenLP[30350:1675949] WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES.
Setting up log file: /Users/jon/Library/Application Support/openlp/libreofficeserver.log
2024-03-15 13:40:32.340 soffice[30376:1676528] WARNING: Secure coding is not enabled for restorable state! Enable secure coding by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState: and returning YES.

jlgtx

For argument's sake, I tried running it from the command line but starting in the app directory, to make sure it wasn't some weird path issue. IOW:

% cd /Applications/OpenLP.app/Contents/MacOS/
% ./OpenLP

That works just fine too, no difference. Still can't open via double-click. So, for a workaround, I created a file named "OpenLP.command" in my home directory, with one line in it:

/Applications/OpenLP.app/Contents/MacOS/OpenLP

I can double-click that file, it auto-launches in Terminal, and OpenLP runs without an issue.