Chords in OpenLP

Godisawesome

@tgc I'll post the  link to download the songbeamer file that I imported that made me aware of the issue later.  Have to say that used your branch for the first time live on a actual church service and it worked flawlessly and the feedback from the church team is really positive 

Godisawesome

@tgc Here the files that show the OpenLP and Songbeamer screenshots and the sng file to import into OpenLP, I have downloaded the 2657 build as was using 2654 build previously, but the issue still remains even with the latest build. I imported the song using the import song method. Songbeamer Screenshot :- https://www.dropbox.com/s/semaxf7rrkikdvu/Ancient%20of%20Days%20-%20Songbeamer.jpg?dl=0 OpenLP Screenshot :- https://www.dropbox.com/s/hiarutqzkekxzdy/Ancient%20of%20Days%20OpenLP.png?dl=0 Songbeamer .sng file :- https://www.dropbox.com/s/dk4at6ktzeqiyo3/ANCIENT%20OF%20DAYS.sng?dl=0

janbadin

@tgc Thank you. I'll test it and give you a feedback. I've found some issues: At first, I'll show you the problem with Bible imported from OpenSong. I know, what the text in square brackets means - it is that, what isn't in some original texts. In written form of this translation are used these special symbols for it -┌ text ┐ Do you have any idea, how could I replace it? <a rel="nofollow" target="_blank" href="http://jpeg.cz/images/2017/05/01/mGtn.jpg" title="Link: http://jpeg.cz/images/2017/05/01/mGtn.jpg">http://jpeg.cz/images/2017/05/01/mGtn.jpg</a> The second issue: When there are more chords, it adds a dash in stage view. In Song editor I have it as one verse, but cause of chords it splits into two parts in Live View. You can see it for example in Chorus 2 - there is one phrase, that is repeated, but there are different chords. Cause of many chords it splits into two parts, so it isn't good for me and musicians too. Could you give me an advice? http://jpeg.cz/images/2017/05/01/PoW14.jpg

tgc

@Godisawesome: I fixed the flat note issue and push it to the branch. It turns out that songbeamer actually saves the "♭" as a "<". But I noticed that in the screenshots you posted that OpenLP imports the chords to the wrong lines, so I'll have to look into that... @janbadin : The first issue you mention is fixed in the new build. I'll have a look at the second issue you mention.

Godisawesome

@tgc thank you for that. I don't think every song is bumping the chords down on to the following line.  I will do some more checks to see which songs do and try and see what causes it. I think it something with the songs rather than a openLP issue. Will come back to you with more details

tgc

@janbadin: looked into the dash-between-chord issue, and unfortunately it is very hard to do much about at the moment. One quick fix should be to insert a space between the chords.

Godisawesome

@tgc thanks for the flat note fix, have tested it successfully just now. i have looked at two songs imported from songbeamer .sng files. One bumps the chords down on a line on all verses except Verse 1, yet another song has imported fine.  This is the file that imports with the chords bumped down a line :-  https://www.dropbox.com/s/kgs9ygn4u13ekxs/ANCIENT%20OF%20DAYS.sng?dl=0 This is the file that imports correctly :- https://www.dropbox.com/s/clxolcyiyea9q4v/10%2C000%20REASONS.sng?dl=0 I not sure where the problem lies, but it doesn't appear to be within OpenLP I would suggest.

Godisawesome

@tgc I have noticed that the media plugin is still disabled, is this going to remain the case until the branch is merged into the trunk?

tgc

@Godisawesome : you need to install mediainfo.

Godisawesome

@tgc ok. Will do that later. Have to investigate another possible issue. The build that fixed the flatnote issue is causing a traceback error. Going to try it on another machine to eliminate any potential cause from the computer in church 

Godisawesome

@tgc this is the traceback text :-  Traceback (most recent call last): File "/home/user2/OpenLP build 2658/chords/openlp/core/ui/themeform.py", line 149, in calculate_lines self.theme_manager.generate_image(self.theme, True) File "/home/user2/OpenLP build 2658/chords/openlp/core/ui/thememanager.py", line 710, in generate_image return self.renderer.generate_preview(theme_data, force_page) File "/home/user2/OpenLP build 2658/chords/openlp/core/lib/renderer.py", line 216, in generate_preview service_item.render(True) File "/home/user2/OpenLP build 2658/chords/openlp/core/lib/serviceitem.py", line 249, in render expand_chord_tags = self.name == 'songs' and Settings().value('songs/enable chords') AttributeError: 'ServiceItem' object has no attribute 'name' The traceback occurs when starting the edit a theme routine and also on the theme manager.Also even though I have installed mediainfo and the media plugin is now enabled, I can add a video using the load new media button, have tried both a mp4 and a webm video and when try to send them live or to preview I get the message :- <img src="https://forums.openlp.org/uploads/editor/h8/9y1ln84v4dty.png" alt="">

Godisawesome

@tgc regarding the video playback, problem solved, removed the system and webkit players off the player list so VLC is the default player and all is fine now. I should have thought about that in the first place!!!!

tgc

@Godisawesome : I just pushed some new fixes to the chord branch. I fixed the traceback you got, and I think I fixed the issue where chords were on the wrong line. My best guess is that it depends on the version of songbeamer that has created the song, so depending on the songbeamer version listed in the file I do some different things - I hope it work, please test!

Godisawesome

@tgc Ok. I will test now.

Godisawesome

@tgc the theme editor is now fine. Unfortunately the chords are still bumped down. It maybe something that is going to be a big job to solve? This is the text that it imported(as a fresh import into Build 2659):- ---[Verse:1]--- B[C]lessing [Dm/]and[C] hon[C]our [C]Glory [Dm/]and[C] pow[C]er Be unto the A[G/]nc[B]ient[Am] of D[G/]ay[B]s F[C]rom [Dm/]ever[C]y nat[C]ion, all of [Dm/]cre[C]atio[C]n [Am7]Bow before the Ancient[G/] of[B] Da[C]ys ---[Verse:2]--- Every tongue in heaven and earth S[F]hall declare you[Dm/]r g[C]lory [G] Every knee shall bow[C/] a[E]t your t[F]hrone in worship[Dm7] You[G] will [C/]be[E] exa[Em7]lted oh God ---[Verse:3]--- And your Kingdom [C/]sh[E]all not pa[F]ss away Oh Anc[Dm7]ient of Da[G]ys ---[Verse:4]--- Your Kingdom shall reign o[C]ver all the earth Sing unto the Ancient of Days [B♭/]For[C] no[F/]n[C]e can co[Gm/]mpa[C]re [B♭/] [C] [C] T[C]o your matchless worth Sing unto the Ancient of Days

petarhorvat1982

HI, i joined the forum because of this CHORD function!.. VERY GOOOD! i like it! what is the right format of the CHORD PRO file for importing. i am trying with the files i downloaded from http://www.worshiptogether.com ChordPro format but as i try to import it says  (Title and/or verses not found) this is the format in the txt file.. what do i need to change / add

Intro

[C // G // D/F# // Em // C // G // Dsus // D //]

Chorus

Bless the [C]Lord O my [G]soul 

[D]O my [Em]soul

[C]Worship His [G]Holy [D]name

Sing like [C]never be[Em]fore 

[C]O [D]my [Em]soul

I'll [C]worship Your [D]Holy [Gsus]name[G]

Verse 1

The [C]sun comes [G]up

It's a [D]new day [Em]dawning

[C]It's time to [G]sing Your [D]song [Em]again

What[C]ever may [G]pass

And what[D]ever lies be[Em]fore me

[C]Let me be [G]singing ?

When the [D]evening [G]comes

Verse 2

You're [C]rich in [G]love 

And You're [D]slow to [Em]anger

Your [C]name is [G]great 

And Your [D]heart is [Em]kind

For [C]all Your [G]goodness 

I will [D]keep on [Em]singing

[C]Ten thousand [G]reasons 

For my [D]heart to [G]find

petarhorvat1982

i even tried to copy the one from the thread above into a txt file.. and also the same error apears

petarhorvat1982

I found the format the title has to be in.. then it works {t:TITLE}

{st:SUBTITLE}

tgc

@Godisawesome: Could you post the file you imported from as well? At this point I'm honestly guessing at why it work with some files, and not with others... Hopefully more examples can make my guesses better :)

Godisawesome

@tgc i will look through for some other songs that are same and send the links later https://www.dropbox.com/s/dk4at6ktzeqiyo3/ANCIENT%20OF%20DAYS.sng?dl=0

« Previous Page Next Page »