Chords in OpenLP

Godisawesome

@tgc that would be great. It not as important as having the main code running correctly, so I can well understand it not been at the top of the list. My initial thoughts were if could somehow add the html colour tags either side of the chords during import? I know that would restrict the colour to only one colour but it's a start!

Godisawesome

@tgc I have done some experimenting, I changed line 192 of openlp/plugins/songs/lib/importers/songbeamer.py to :- line = line[:int_idx] + '{r}' + '[' + self.chord_table[line_number][idx] + ']' + '{/r}' + line[int_idx:] This adds the openlp html tag for red text. It works in a fashion in that the chords are displayed in red but underneath a '-' symbol is placed in the lyrics (also in red). I also noticed on line 235 of songbeamer.py the following line :- elif tag_val[0] == '#ColorChords': Could be that if add a #ColorChords tag into the .sng files that this will change the chords color? Also, I spotted something about a python library called colorama that sets text color, I am going to do some more testing on that, if you think that might be workable? Images below show a song with the original songbeamer.py and the one with the revised songbeamer.py  <img src="https://forums.openlp.org/uploads/editor/3w/6n9dzf4cdg8c.png" alt="" title="Image: https://forums.openlp.org/uploads/editor/3w/6n9dzf4cdg8c.png"> <img src="https://forums.openlp.org/uploads/editor/y4/98bozcww0mnq.png" alt="">

Godisawesome

@tgc Just discovered another "bug" during testing during the service at church today. I have to graciously thank you for the work you have put in to the project, the response from church leadership has been really positive. What I discovered today is that in the ASV and KJV bibles some words are surrounded by square brackets, these words appear to been treated as chords and are on the line above the rest of the bible verse. Every blessing, Paul

janbadin

@tgc Hello, I'm very interested in your project to OpenLP. I would like to test it in our church. We've been looking for something like that for many months, so I'm glad, that I find that. But there is one problem - I can't download it from link you've shared there, it says me: Project not found or access denied. Could you send me the latest version? God bless You, Jan

Godisawesome

@janbadin Are you using Windows or Linux?

tgc

@Godisawesome: good catch, I'll see if I can find a way to avoid that. @janbadin: I'll try to make a build available within a few days.

Godisawesome

@tgc thanks for that, I have downloaded the King James Version of the bible from the open song website which as far as I can tell doesn't use square brackets, so that might be the easier option in the interim? 

tgc

@Godisawesome: Yes, using a "clean" version of KJV is probably a good solution for now.

Regarding your color-experiments, I would recommend not recommend putting formatting tag inside the brackets, since that will make confuse the "layout calculator" which then inserts dashes and in your tests... The best solution would be to integrate it into the themes, but unfortunately I don't have the time to do that now.

The "#ColorChords" tag in SongBeamer is not imported into OpenLP, since OpenLP does not allow specific formatting to be set on each song. In OpenLP we use themes and songs can be linked to themes instead, but not during import.

The colorama python packages is not applicable here, since it is meant for console output, while OpenLP relies in HTML rendering.

Godisawesome

@tgc thank you for your response, I'm relatively new to python programming so just getting to grips with the inner workings of OpenLP.  Will give the "clean" bible versions a trial over the next few Sundays to check it performs well and feedback on it.

janbadin

@Godisawesome I use Windows. @tgc Thank you for your fast answer.

STEPHANVS

I also noticed that, if a Bible version contains "." in the book name (like "1. Peter"), then the quick searching is not working, I have to use the advanced search. It is working in 2.4.2

janbadin

I have a little problem - one of Bible translations - Czech Study Bible translation (we use that at most) has some words in the text in square brackets, so how could I delete them from the text or replace them with parentheses?

Godisawesome

@janbadin have you looked at this website?http://www.crosswire.org/study/fulllibrary.jsp?action=closeAll&open=Biblical+Texts

Godisawesome

@tgc just picked up on another problem if there is a flat chord in a song then the flat symbol is displayed as a < symbol instead of a flat.

Godisawesome

@tgc just found this on wikipedia about the flat symbol that may help :- The Unicode character ♭ (U+266D) can be found in the block Miscellaneous Symbols; itsHTML entity is &#9837;.

janbadin

@Godisawesome I've looked there, but the translation we need wasn't there. I've found only version for OpenSong, so I imported it.

Godisawesome

@janbadin Opensong bibles do seem to be the best ones to use. 

tgc

@Godisawesome: I'll have a look at the flat-problem. Thanks for testing. Btw, I've fixed the bible-tag issue in the branch. I'm having some issues making a windows build, but I hope to overcome them...

Godisawesome

@tgc thanks for that. That's why I prefer Linux,  far less troublesome 

tgc

@Godisawesome: I cannot reproduce the flat-node-issue, could you provide some more details on how to reproduce? @janbadin : I've made a windows build of the current chord code: https://ci.appveyor.com/project/OpenLP/dev/build/OpenLP-win-ci-b10/artifacts

« Previous Page Next Page »