Chords in OpenLP

tgc

@STEPHANVS: Yes, I have changed the code to work better with bass chord etc.<br>The latest build can be found here: https://ci.appveyor.com/project/TomasGroth/openlp/build/OpenLP-win-ci-b154/artifacts<br><br>

STEPHANVS

@tgc: first test looks awesome! Also in my config there was something cached, theme feature is also working fine!

STEPHANVS

@tgc: Well done! All of my initial tests were successful! You even fixed the search lyrics function! Once again, congrats, well done!

STEPHANVS

@tgc: one thing is missing until now: languages/translations :smile:<br>Do you know how to get them in this build?

Godisawesome

I have found a issue of importing songbeamer songs into the OpenLP Chords branch, the chords are imported but for some reason the first line of the song is missing the chords, has this been highlighted already?

tgc

@STEPHANVS: thank you for testing! Translations can be added, but I'll wait until the branch has been officially merged.<br><br>@Godisawesome : I have not seen the issue you mentions. Could you provide an example?<br>

Godisawesome

@tgc I not by computer at moment but when get chance i'll attach screenshot and the associated songbeamer file for you to test out.

Godisawesome

Here is the link to one of the songbeamer files that isn't importing the first line of the chords :-<br><br>https://www.dropbox.com/s/clxolcyiyea9q4v/10%2C000%20REASONS.sng?dl=0<br><br>This is how it is imported into OpenLP, having looked it more closely the chords are been imported but are starting from<br>the second line of the song instead of the first, maybe because songbeamer displays the song title where OpenLP isn't?<br> <br><img src="https://forums.openlp.org/uploads/editor/c4/54kmzbgzx83q.png" alt="" title="Image: https://forums.openlp.org/uploads/editor/c4/54kmzbgzx83q.png"><br><br>This is how it appears in songbeamer :-<br><br><img src="https://forums.openlp.org/uploads/editor/n5/y13bslg9hlb4.jpg" alt=""><br><br><br>

raoul

It doesn't look like the first line is missing, it actually looks like the chords are bumped onto the next line, so line 1's chords are above line 2.

Godisawesome

Yes, I realised that after I had posted it, I'm wondering if I remove the title from the original songbeamer file and see if that solves the problem<br>

tgc

@Godisawesome I've found and fixed the problem with the missing/bumped line when importing songbeamer songs. Would it be possible for you to provide an example file with a song that is not copyrighted? That way I can include it in our testsuite and thus make sure it will always work.<br>

Godisawesome

Thank you, will do that later. Am I right in assuming that cannot post the file directly to the forum and need to share a dropbox/googledrive link to the file?

tgc

@Godisawesome: yes, you'll need to make the file available elsewhere and then put the link here.<br>

Godisawesome

That's not a problem. I have a song that is my own, so it not copyrighted will send that one. 

Godisawesome

Here are the links to the files for the song (I have included the screenshots of both the Songbeamer version and the equivalent of after importing into OpenLP) :- <br><br>Songbeamer SNG File

<br>

https://www.dropbox.com/s/fc0tvcfzd85ik7i/When%20I%20Call%20On%20You.sng?dl=0</div><div><br></div><div>Songbeamer Verse 1

<br>

https://www.dropbox.com/s/2jxqj1s79zag825/SongbeamerV1.png?dl=0</div><div><br></div><div>Songbeamer Verse 2

<br>

https://www.dropbox.com/s/3i9nqnkcksll298/SongbeamerV2.png?dl=0</div><div><br></div><div>OpenLP Verse 1

<br>

https://www.dropbox.com/s/lzzez6r8mcpkc2x/OpenLPV1.png?dl=0</div><div><br></div><div>OpenLP Verse 2

<br>

https://www.dropbox.com/s/sr2dl8kah77bt21/OpenLPV2.png?dl=0</div>

Godisawesome

@tgc has the fix for the songbeamer import issue been incorporated into the openlp chords branch? If not could you supply details of the changes needed so I can manually change the required files? Thanks in advance

tgc

@Godisawesome: yes, the fix is in the branch. I hope to "finish" the branch rather soon, but life keeps happening...<br>

Godisawesome

@tgc Thanks for that, I really appreciate the effort that has gone into this. <br><br>Will have a look at it later on to start putting it into our "offline" machine. <br><br>Thanks again.

Godisawesome

@tgc just tested the songbeamer import. It works great thank you.<br><br>Just a suggestion for a future improvement, whether it is a big job to add but it would be great if could be able to have the chords in a different colour to the lyrics so they stand out more.<br><br>From what I can see it not straightforward as the font colour is chosen in the theme editor, so would involve a change of the theme editor interface as well as behind the scenes code.

tgc

@Godisawesome: Thanks for testing! <br>I've considered adding color of chords as a theme option, but I've postponed it to a later point... <br>

« Previous Page Next Page »