Chords in OpenLP

tgc

@petarhorvat1982: Good to hear you made it work. So the title was not originally in the files? If not, was the title in the filename?

tgc

@Godisawesome : If you could find some examples without copyright, as well as having the issue that would be great :-)

Godisawesome

@tgc I'm not able to post up any of the songs as they will all be copyrighted unfortunately. What I can do is try typing some words and chords in Songbeamer with a few verses and see if I can identify a cause and report back on my findings :-)

Godisawesome

@tgc I think the problem is something to do with Songbeamer and not OpenLP as I opened up Songbeamer to check the Ancient of Days song and the chords are also bumped down a line as well now. I think what might have caused it to change was that in Songbeamer the second verse had the word Chorus on a blue background before the lyrics of the verse. I deleted the line with chorus on it and it seemed to be after that when the chords were on the wrong lines in Songbeamer. That maybe a starting point to investigate further on this. I will look more into it from the Songbeamer side of things.

Godisawesome

@tgc Have just found this on the songbeamer forum about the encoding of the *.sng text file, would this have any impact on the import? SongBeamer accepts 4 encodings for sng files: ANSI, UTF-8, Unicode, Big-Endian-Unicode.  When reading a *.sng file, SongBeamer takes a look at the byte order mark (first 2-3 characters of the sng file). This will determine the encoding that is used when reading the file. If there is no byte order mark, then SongBeamer assumes that the file is ANSI with codepage 1252. We don't use heuristics for detecting UTF-8 files as this could lead to unpredictable results.  The byte order mark for UTF-8 is $EF $BB $BF. So if your file starts with these 3 bytes and it is UTF-8 you'll be fine.

tgc

@Godisawesome: The encoding issue is handled by the current trunk and also the chord branch. Regarding the chorus-heading, I think you are on to something. OpenLP checks if the first line of a verse is "verse", "chorus" or similar and then assumes it is a verse tag and then ignores it in relation to chords. So if "chorus" is entered manually, then we have a problem! So the real issue is how to figure out when verse tags are entered manually, and when they are inserted by Songbeamer.

Godisawesome

@tgc seems like we are heading in the right direction by identifying the possible cause.

tgc

@Godisawesome: I've attempted a new approach where I try to detect if the verse tags are manually inserted or not. I've pushed the code to the branch, so feel free to test :)

Godisawesome

@tgc will have a look and let you know if to works

Godisawesome

@tgc Just tested build 2661 with the song that was problematic.-It importred perfectly this time. So looks like can mark that has problem solved :-)

tgc

@Godisawesome: That is good news! I'm glad we was able to solve it :)

Godisawesome

@tgc just going through the songs we are using and it seems that if have an apostrophe in a word e.g I'M it gets shown as I - 'M if there is a chord immediately before it. If I remove the chord it displays correctly 

tgc

@Godisawesome: could you share the complete line? I'm curious if there are more chords on line...

Godisawesome

I will do so when get home :-)

Godisawesome

@tgc here are a couple of the lines causing the problem :- I[C]'ve got [C]my mind m[C/]a[G]de up

I[D]'M NOT MOVED BY WHAT I SEE HALLE[F]LUJA[C]H I tried removing all the chords except the one before the apostrophe and it is still the same, the only way that works is to move the chord after the apostrophe as a temporary solution in the interim

tgc

I figured out a fix for this and pushed it to the branch.

Godisawesome

@tgc thank you, will bzr it down later :-)

tgc

The chord code has now landed in OpenLPs main source code repository.

janbadin

@tgc Congratulations!

Godisawesome

@tgc Yes, that is now working fine. We have been using it in our services so far is running very stable, did have a issue with the Linux installation itself but OpenLP itself is running great, been able to play videos on the projector direct from OpenLP is really useful and the feedback so far is really positive :-)

« Previous Page Next Page »