Chords in OpenLP

tgc

@dm82david please start a new thread or drop by in IRC.

tgc

Hi,

Just another update on the chord support I'm working on, based on the work posted here. I got a new build I'd like you to test :)

The current features are:

* Support for chords in ChordPro format.

* Display chords on new stageview (available on http://<ipaddress>:<port>/chords).

* Display chords on mainview (if enabled in song settings).

* Import from the following formats: OpenLyrics, OpenSong, VideoPsalm.

* Export to OpenLyrics format.

There are still some features missing, such as printing song with/without chords.

The code is available from this branch: lp:_tomasgroth/openlp/chords

Or if you're on windows you can get a build from here: https://ci.openlp.io/view/Branch/job/Branch-06-Windows_Installer/44/</div></div>

bishopm

Just had a look at this tonight - great work! I've been hoping this would be added at some stage. I'll play with it some more and give some more detailed feedback, but the quick test I gave it on Linux Mint looked outstanding. Thank you!

Michael

tomasss

Big thanks @tgc. I tried to import my songs with chords, but there was an error when I wanted to view this lyrics:

Traceback (most recent call last): File "openlp\core\lib\mediamanageritem.py", line 477, in on_selection_change File "openlp\core\lib\mediamanageritem.py", line 491, in on_preview_click File "openlp\core\lib\mediamanageritem.py", line 626, in build_service_item File "openlp\plugins\songs\lib\mediaitem.py", line 611, in generate_slide_data File "openlp\plugins\songs\lib\openlyricsxml.py", line 322, in song_to_xml File "openlp\plugins\songs\lib\openlyricsxml.py", line 473, in _add_text_with_tags_to_lines ValueError: unexpected '{' in field name

chords format is:{cl}Ako {c}[Hm]{/c}rieka {c}[A]{/c}{/cl}

But when I use chords only in brackets then it's ok: Ako [Hm]rieka [A] And I check that you used old version of "slide.html". There are also option chords on/off and size of fonts in my newer version of html (https://github.com/tomasss1024/openlp_chords)

tgc

@tomasss @bishopm thank you for testing!

@tomasss  The error you see is unrelated to the chord changes, but it will of course have to be fixed anyway. The error prevents importing any OpenLyrics-formatted song with formatting tags.

I left out the on/off and zoom buttons and the font changes because I did not want to introduce these features in the chord-stageview, which is more or less just an extension of the the existing stageview. If these changes should be added, they should go into the main stageview first. I also left out the on/off button since this is now a dedicated chord stageview, so the assumption was that you actually want to see chords if you use it.

rohanlori

Thanks for working on the chords, they work awesome! 

I had a couple questions. I installed using the file, OpenLP-2.4.1-bzr2614-setup. 

I notice that the media plugin is disabled and the checkbox for status (active) is greyed out. Any idea why? 

Second question is regarding the browser displaying the chords webpage. My iphone6, android phone and PC show the webpage fine. However using chrome or safari on my ipad, the page starts to zoom in (so you can't see all the lyrics/chords) as you go through the different slides in a song. Same thing happened on another ipad. 

johnwry

I have downloaded the last version of chords available on this thread. I thought for sure the transpose + - options would be there but nothing...can anybody tell me why it does not show up?? 

Thanks so much for all your help to make this work!!!

rohanlori

When I installed the build that TGC mentioned above, the transpose options worked perfectly.

"Or if you're on windows you can get a build from here: https://ci.openlp.io/view/Branch/job/Branch-06-Windows_Installer/44/"

I just had problems with the media plugin and ipads displaying the chord page as mentioned in my previous post.

tgc

Thanks you for testing @rohanlori and @johnwry

@rohanlori The media plugin is disabled because the test-build-server is not fully up to date when it comes to handling some of the changes in the media plugin - unrelated ti chords. Maybe I can get it fixed before the next test build. The zoom issue you mention is a known bug on iOS: https://bugs.launchpad.net/openlp/+bug/1503689  Hopefully we can find a workaround.

@johnwry It sounds like you looked at the standard stage view, you need to use the new chord stage view.

jgagianas

Hello, 

Thank you for making this software first of all. It has been a blessing to my church for the past 4 months. This past month, we were talking about adding chords for the musicians and this beta version appeared. Today during the worship practice however, we noticed how even if I put in the chord as Bb, it shows up in chord view as A#.  I understand that those are the same chords, however when playing piano, it is tough to change it up on the fly. Is there any way to make it show up exactly how I type in the chord? In the OpenLP software, it still says Bb, however in chord view it changes all the "flats" to the "sharp" equivalent.  

Thank you so much in advance and thanks for all the volunteers that put in all their hard work!

STEPHANVS

@jgagianas: there is a line in .js file:

notesPreferred = ['-', '#', '#', 'b', '#', 'b', '#', '#', 'b', '#', 'b', '#'];

change it to:

notesPreferred = ['-', '#', '#', 'b', '#', 'b', '#', '#', 'b', '#', '#', '#'];

The reason for this behavior is the transpose function, and that there is no property for the song, that would define the proper notation of each chord. For example in F# major the proper notation for 3 is A#, but in F major 4 is Bb (or B in the german system). We could code the chord of the song in hidden HTML, like the chords are currently, but I had no time to do it yet. You can manipulate the shown chords by altering the notesPreferred, notesSharp, notesFlat variables. Also adding the green lines would show the original chords, if no transpose is active:

notesPreferred = ['-', '#', '#', 'b', '#', 'b', '#', '#', 'b', '#', 'b', '#'];

if (transposeValue == 0 ) {

return chord;

} else {

for (i = 0; i <= chordSplit.length - 1; i++) {

...

return transposedChord;

}

jgagianas

@STEPHANVS:

Just to be clear, is this in the AppData\Roaming\openlp\data\Stages\Chord view\stage.js\ file? 

I can't seem to find any other .js file.  But I don't see that line anywhere in stage.js. 

STEPHANVS

@jgagianas: What version OpenLP are you using? Did you create the custom stage, if so, which zip files did you download?

tgc

@STEPHANVS He is using the test-build I linked to earlier. @jgagianas  You will find the chords.js in "c:\program files (x86)\openlp\plugins\remotes\html\js\"

jgagianas

@tgc I was able to find the chords.js file. However in notesPreferred, it shows like this notesPreferred = ['b','#','#','#','#','#','#','#','#','#','#','#']. I would like everything to show b except C# and F#.  Per our pianist.  I hate to be a pain, but can you help me accomplish this?

STEPHANVS

@jgagianas: notesPreferred = ['b','#','b','b','b','b','#','b','b','b','b','b']; The logic here is that the transpose function will pick the string from notesSharp or notesFlat, depending on the value found in notesPreferred. There are 12 values in each, representing the 12 notes of an octave. I do not know why the notesPreferred in your file looks like that, but basically you can use 3 values in notesPreferred (let's take C#/Db, the 2nd value from the array as an example): - 'b': string from notesFlat will be used (in this case 'Db') - '#': string from notesSharp will be used (in this case 'C#') - '-' (or any other character): notation preference is not forced

Captainlatte

To everyone working on the chord software Thankyou! this is is fantastic. We (our church) need to wait for this feature before converting over from OpenSong because we have so much time invested in entering Chords in our OpenSong database, so I have been periodically dropping in to see what you are doing. I tried the windows build in the thread above and I could easily import all our OpenSong songs with chords and the stage/chord view through browser works really well (awesome and thanks!). A couple of questions 1. Is printing of songs with Chords on the radar and if so do you have any approximate ETA? It would be possible to print from a browser in stage mode if text was not so big. Would it be possible to add text size adjustment to the stage/Chord view  2. Is their a MAC version of this update? 3. (and much less important) will the chord view be supported in the android/iphone app as well? Thanks for all the wok you guys are doing.  David

tgc

@Captainlatte Great to hear you can use the feature :-) To answer your questions: 1. Yes, printing will be supported, but it has proven to be a bit more tricky than first thought. 2. No Mac build is available yet, we do not have any developers using Mac as their main platform. 3. Yes, chord view should come to the apps as well.

tomasss

@Captainlatte: 1. I made print.html described in this comment. Unpack my zip file into correct directory and you can check http://localhost:4316/files/print.html

focusp

@tgc thank you for this great feature. Have you had a chance to get the media plugin working with a chords build yet? 

« Previous Page Next Page »