Chords in OpenLP

johnwry

Anybody know where these files are on mac?

STEPHANVS

@johnwry: I do not own a mac, but if I remember correctly I had to browse the app and copy them into the proper directory inside the app.

STEPHANVS

Me again. This time I did not keep track of all the changes I included in these files, so forgive me, if I leave something out:

- main reason for posting: mid-song transpose support (guitar players can see set per-slide transpose/capo values, and they are shown before next slide, and also main value display flashes red for 5 seconds)

- added android/ios add2homescreen support with icons

- improved onthefly transpose changing speed

Backward functionality breaking features!!!:

- renamed files to chords.*

- changed transpose value assignment logic, will ignore currently stored values in localstorage of the browser

Tested with version 2.2.1 (newer versions seem a lot slower on search, and songbook view sorting is broken...)

chords.zip

God bless you all.

STEPHANVS

About the new transpose storing:Adding the following lines in chords.js (after line 105 in loadslides function) will preserve/migrate the currently saved transpose settings of songs:if (localStorage.getItem(OpenLP.currentSlides[0].text.split("\n")[0] + 'transposeValue')) {      localStorage.setItem(OpenLP.currentSlides[0].text.split("\n")[0] + 'transposeValue[0]',localStorage.getItem(OpenLP.currentSlides[0].text.split("\n")[0] + 'transposeValue'));//this line copies old format settings to new format settings      localStorage.removeItem(OpenLP.currentSlides[0].text.split("\n")[0] + 'transposeValue');//this line removes old format settings }

tomasss

Thanks @STEPHANVS I compare your changes to my code and I decided to upload my work to github (download as zip). I have some additional controls (chords on/off), print.html, .. etc. in it. So I will try to merge your changes to my code or .. you can do it better :) God bless you.

STEPHANVS

@tomasss: I could not yet find the time to look into "full involvement" in development, I hope this year I will manage to get in. In the meantime you are doing a favor for all of us by implementing.

tgc

Hi @STEPHANVS and @tomasss,

I don't know if you've noticed, but OpenLP 2.4 have introduced Custom Stage View, which could be useful for your chords-stageview: https://manual.openlp.org/stage_view.html#custom-stage-views</div><div> </div><div>As mentioned earlier I've started a branch based on your work here. Will do some more work on it within a few weeks.

STEPHANVS

@tgc: thanks, will check it out

<div> </div>I promise this will be my last contribution here, will catch up with the official contribution channels :D

So, in one of my earlier posts I stated, that chord preference cannot be determined by algorithm, and songs have to have a chord property... I might have to contradict myself, as I did manage to work out a pretty close code for it in chords.js:

var lastChord;

var lastChordPreference;

var chordSplit = chord.replace('♭', 'b').split('/'), transposedChord = '', note, notenumber, rest, currentChord, lastBass,

var chordSplit = chord.replace('♭', 'b').split('/'), transposedChord = '', note, notenumber, rest, currentChord, lastChord, lastBass,

notesPreferred = ['b', '#', '#', 'b', '#', 'b', '#', '#', 'b', '#', 'b', '#'];

notesPreferred = ['-', '#', '#', 'b', '#', 'b', '#', '#', 'b', '#', 'b', '#'];

lastChord = notesPreferred[notenumber] === '#' ? notesSharp[notenumber] : notesFlat[notenumber];

lastChordPreference = notesPreferred[notenumber];

if (notesPreferred[notenumber] === '#') {

lastChord = notesSharp[notenumber];

} else if (notesPreferred[notenumber] === 'b') {

lastChord = notesFlat[notenumber];

} else {

lastChord = notesSharp[notenumber];

}

lastBass = notesSharp.indexOf(lastChord) === -1 ? notesFlat[notenumber] : notesSharp[notenumber];

if (lastChordPreference === "#") {

lastBass = notesSharp[notenumber];

} else if (lastChordPreference === "b") {

lastBass = notesFlat[notenumber];

} else {

if (notesPreferred[notenumber] === '#') {

lastBass = notesSharp[notenumber];

} else if (notesPreferred[notenumber] === 'b') {

lastBass = notesFlat[notenumber];

} else {

lastBass = notesSharp[notenumber];

}

Now transposing is reflecting my personal taste (hopefully correct one) of sharp/flat representation of chords.

dm82david

I made some small mods to txt_to_openlyrics.html here is the result: txt_to_openlyrics_mod_01.html

added save button;

added [c] tag button for fast inserting "[c]" at cursor position

page fit well on small screens (mobile phones)

OpenLyrics Gen v0.2 Link will be available until August 31, 2016.

David M.

JGE

I'm very impressed by the new OpenLP version 2.4.1 as it can display chords on a stage view for musicians on smart phones and it seems also on other PCs (I have not tried the latter). I have been looking for these features for about a year now and tried different song projection softwares (freeware). So OpenLP is the best till now and I hope that what you guys are coding here can be merged into the next release. So far it's rather difficult to figure out how to implement these features for people who are not familiar with tags and directory systems etc.

We have been using OpenSong for many years and since a year with the OpenSong Tab App we can display songs on smartphones and tabs, but that is tedious to sync all the files. As we have several hundreds of songs in the OpenSong format and most of them have chords, I have been searching for a way to convert these and import them into OpenLP. I have tried the import feature in OpenLP but it strips out all the chords. The only thing that works is the file file txt_to_openlp_en.html (by tomasss), but that works only with copy and paste, convert in that page and then paste into the OpenLP lyrics editor. That's good and works well, but it's very tedious and time consuming for hundreds of songs. Could this be modified into a batch file or a small exe program so that it can be run with many song files. Or could it be included in the "import OpenSong songs" function of OpenLP? That would be a great help! Does OpenLP import lyrics with chords from any other file format? Thanks for all your work!

Christina

@JGE: Out of curiosity, what other freeware displaying chords did you try ?

JGE

I tried the free ones, mainly VideoPsalm (very good with lots of good features, but no stage view yet) and Quelea (quite simple to use, has good features including stage view and remote control, was able to import songs with chords, BUT the chords are not displayed at the right words). I tried several others, but they all lacked in features or were not working well.

tgc

@JGE: Currently OpenLP does not support importing of chords from any format. I hope to change this before the 2.6 release where I hope to get chords support ready. I wont promise anything though...

tgc

hi @STEPHANVS and @tomasss I've now created a branch which includes some of the chord-code you made. I've created a new chord-webview where the chords are shown, see the link under the remote settings. I've also added support for different chord-notations (german/english/neo-latin), you can chose in the settings. Transposing of chords is also possible in the lyrics editor. @STEPHANVS , I could not make your code work, but if you are willing to make a patch I'll try to integrate it. You can download a test-build of the branch from: https://ci.openlp.io/view/Branch/job/Branch-06-Windows_Installer/42/ Some feedback would be appreciated :)

dm82david

Hi tgc I modified an old source (2.0.5) on my home computer. How do I compile it for windows, so I can use it at church? I couldn't send a pm, so I posted here (sorry about that). Thanks,                    David M.

tomasss

Great news, super, thanks @tgc. I am so busy now and I check it only for short time. But I don't know why, I cannot import my songs with chords. There are some error: .. _process_lines_mixed_content_process_lines_mixed_content ValueError: unexpected '{' in field name There are some funcionality missing on chords screen from my last update: - show/hide chords - +/- font size It's on good way. Thanks. Tomas

tgc

@dm82david, compiling on windows is not so easy... First try to move to the latest release ~ 2.4 or development trunk, and then read http://wiki.openlp.org/Windows_Environment and then checkout https://code.launchpad.net/~openlp-core/openlp/packaging and look at the comments in the top of windows/windows-builder.py

tgc

@tomasss The import error was unrelated to the chord-changes, but should be fixed now in the branch and in this build: https://ci.openlp.io/view/Branch/job/Branch-06-Windows_Installer/43/

emanueloa

Hello Tgc The problem is on the line 461 on the file openlp/plugins/songs/lib/openlyricsxml.py: text = text.replace('{/{tag}}}'.format(tag=tag), '</tag>') change to text = text.replace('{{/{tag}}}'.format(tag=tag), '</tag>') Att. Emanuel

dm82david

I have already set the environment for old 2.0.5 release, I have a windows-builder.py from version 1.9.9. I used from openlp/packaging revision 12, but at some point got an error. I will try some other day. Thanks for help!                David M.

« Previous Page Next Page »