Bug while importing songs from Songbeamer

joe

I am trying to import Songs with Chords from Songbeamer into OpenLP. Sometimes the chords appear not in the correct line but one line below. I did some testing and found out:

If the individual verses have titles such as "Refrain", "Verse 1" etc., the error occurs. If the verses are only separated by "---", the chords are placed over them correctly.

If I delete the verse lines in the .sng file, the chords are still integrated incorrectly.
If I replace the verse line with an empty line, the chords are inserted correctly (but the empty line remains in the OpenLP import).
Conclusion: The OpenLP import function discards the line with the verse information BEFORE the chords are integrated into the text, so that the line information is no longer correct.

The OpenLP wiki also provides information about the songbeamer format.
You can use the song below to reproduce the bug. The text is public domain. Whether the chords are, I don't know.

#LangCount=1
#Title=Großer Gott, wir loben Dich
#Editor=SongBeamer 4.11b
#Version=3
#Format=F/K//
#TitleFormat=U
#OTitle=Großer Gott, wir loben Dich
#Author=4. Jh. / Ignaz Franz (1719-1790)
#Chords=MCwxLEQyDTcsMSxCPW03DTE4LDEsRW03DTIzLDEsRC9GIw0wLDIsQj1tNw0xMCwyLEI9bTcvQQ0xOCwyLEVtNw0yNCwyLENhZGQ5DTAsMyxEMg04LDMsQj1tNw0xOCwzLEVtNw0yMywzLEQvRiMNMCw1LEI9bTcNNyw1LEI9bTcvQQ0xNCw1LEVtNw0yMCw1LENhZGQ5DTAsNixFbTcNNyw2LEdtL0I8DTE3LDYsRDINMjMsNixEMi9GIw0wLDcsRw0xMSw3LEQvRiMNMTcsNyxDYWRkOQ0wLDgsRDINMiw4LEQyDTQsOCxHYWRkOS9EDTEwLDgsR202L0QNMCwxMSxEMg03LDExLEI9bTcNMTYsMTEsRW03DTI0LDExLEQvRiMNMCwxMixCPW03DTksMTIsQj1tNy9BDTEzLDEyLEVtNw0xNywxMixDYWRkOQ0wLDEzLEQyDTgsMTMsQj1tNw0xNiwxMyxFbTcNMjQsMTMsRC9GIw0wLDE1LEI9bTcNNS41LDE1LEI9bTcvQQ0xNiwxNSxFbTcNMjIsMTUsQ2FkZDkNMCwxNixFbTcNNiwxNixHbS9CPA0xNiwxNixEMg0yMSwxNixEMi9GIw0wLDE3LEcNMTAsMTcsRC9GIw0xOC41LDE3LENhZGQ5DTAsMTgsRDINMiwxOCxEMg00LDE4LEdhZGQ5L0QNMTAsMTgsR202L0QNMCwyMSxEMg04LjUsMjEsQj1tNw0xNywyMSxFbTcNMjIsMjEsRC9GIw0wLDIyLEI9bTcNOCwyMixCPW03L0ENMTcsMjIsRW03DTIzLjUsMjIsQ2FkZDkNMCwyMyxEMg04LDIzLEI9bTcNMTQuNSwyMyxFbTcNMjIsMjMsRC9GIw0wLDI1LEI9bTcNOCwyNSxCPW03L0ENMTQsMjUsRW03DTIyLjUsMjUsQ2FkZDkNMCwyNixFbTcNOCwyNixHbS9CPA0xNywyNixEMg0yNCwyNixEMi9GIw0wLDI3LEcNNiwyNyxEL0YjDTE1LjUsMjcsQ2FkZDkNMCwyOCxEMg0yLDI4LEQyDTQsMjgsR2FkZDkvRA0xMCwyOCxHbTYvRA0wLDMxLEQyDTksMzEsQj1tNw0xNi41LDMxLENhZGQ5DTIyLjUsMzEsQj1tNw0wLDMyLEQvQQ0xMCwzMixFL0ENMTUsMzIsRW03DTIyLDMyLENhZGQ5DTAuNSwzMyxEMg02LjUsMzMsQj1tNw0xMiwzMyxDYWRkOQ0xOC41LDMzLEI9bTcNMCwzNSxEL0ENOC41LDM1LEUvQQ0xNy41LDM1LEVtNw0yNSwzNSxDYWRkOQ0wLjUsMzYsRW03DTksMzYsR2FkZDkNMTYsMzYsRC9BDTIxLjUsMzYsRDIvQj0NMC41LDM3LEcNOS41LDM3LEQvRiMNMjQsMzcsQW03DQ==
#VerseOrder=Vers 1,Vers 2,Vers 3,Vers 4
#SongQA=TCLIP
#Key=D
---
Vers 1
Großer Gott, wir loben Dich;
Herr, wir preisen Deine Stärke.
Vor dir neigt die Erde sich
--
und bewundert Deine Werke.
Wie Du warst vor aller Zeit,
so bleibst Du in Ewigkeit.

---
Vers 2
Alles, was Dich preisen kann,
Cherubim und Seraphinen,
stimmen Dir ein Loblied an,
--
alle Engel, die Dir dienen,
rufen Dir stets ohne Ruh:
"Heilig, heilig, heilig!" zu.

---
Vers 3
Heilig, Herr Gott Zebaoth!
Heilig, Herr der Himmelsheere!
Starker Helfer in der Not!
--
Himmel, Erde, Luft und Meere
sind erfüllt von Deinem Ruhm;
alles ist Dein Eigentum.

---
Vers 4
Herr, erbarm, erbarme Dich.
Lass uns Deine Güte schauen;
Deine Treue zeige sich,
--
wie wir fest auf Dich vertrauen.
Auf Dich hoffen wir allein:
Lass uns nicht verloren sein.

joe

I poked around in the source code of OpenLP and found a part which maybe has to do with the problem (songbeamer.py, line 178ff):

                   if verse_start:
                        verse_start = False
                        verse_mark = self.check_verse_marks(line)
                        # To ensure that linenumbers are mapped correctly when inserting chords, we attempt to detect
                        # if verse tags are inserted manually or by SongBeamer. If they are inserted manually the lines
                        # should be counted, otherwise not. If all verses start with a tag we assume it is inserted by
                        # SongBeamer.
                        if first_verse and verse_tags_mode == VerseTagMode.Unknown:
                            if verse_mark:
                                verse_tags_mode = VerseTagMode.ContainsTags
                            else:
                                verse_tags_mode = VerseTagMode.ContainsNoTags
                        elif verse_tags_mode != VerseTagMode.ContainsNoTagsRestart:
                            if not verse_mark and verse_tags_mode == VerseTagMode.ContainsTags:
                                # A verse mark was expected but not found, which means that verse marks has not been
                                # inserted by songbeamer, but are manually added headings. So restart the loop, and
                                # count tags as lines.
                                self.set_defaults()
                                self.title = file_path.stem
                                verse_tags_mode = VerseTagMode.ContainsNoTagsRestart
                                read_verses = False
                                # The first verseseparator doesn't count, but the others does, so linecount starts at -1
                                line_number = -1
                                first_verse = True
                                idx = -1
                                continue
                        if not verse_mark:
                            line = self.insert_chords(line_number, line)
                            self.current_verse += line.strip() + '\n'
                            line_number += 1
                        elif verse_tags_mode in [VerseTagMode.ContainsNoTags, VerseTagMode.ContainsNoTagsRestart]:
                            line_number += 1
                    else:
                        line = self.insert_chords(line_number, line)
                        self.current_verse += line.strip() + '\n'
                        line_number += 1

I am not a programmer, I mostly read the comments. It looks like there is some guessing going on, and maybe in my case it's wrong guessing?

tgc

Hi @joe
Thank you for the detailed description of the issue, both this one and the other one you've posted about. I will look into them when I get some time, hopefully within this week.

tgc

So... It turns out that one of the sample songbeamer files we used to test our songbeamer-chords import with was malformed, leading to the weird issues you were seeing. I've made a fix and hope to get it included in the next release.