Songs with Audio

PaulRowell

I'm doing some testing with the portable version before we upgrade to the current version from the 2.4.6 version.

Should everything work if I copy the data folder from the 2.4.6 version to the portable data folder?

If this should work then I've noticed that songs with audio files cause an exception when I try to edit or add to a service or send to live.

echan101

Yeah actually I just tried this. It was unstable for a bit but it seems to be ok after a couple of loads and unloads. After you copy over the data directory and restart OpenLP, shut OpenLP down then delete data/openlp.ini otherwise any audio will just start playing regardless of your autoplay settings.

echan101

O no wait I am still getting the issue with old songs, I can't even delete these songs with audio files. New songs are ok.
Anyway this is a deal-breaker, because it means that if one MP3 moves or you move the portable folder then you can't delete the song or edit the song.

2024-06-16 18:06:47,852 MainThread root CRITICAL Traceback (most recent call last):
File "openlp\core\ui\servicemanager.py", line 1819, in drop_event
File "openlp\core\common\registry.py", line 147, in execute
File "openlp\core\lib\plugin.py", line 250, in process_add_service_event
File "openlp\core\lib\mediamanageritem.py", line 600, in on_add_click
File "openlp\core\lib\mediamanageritem.py", line 621, in add_to_service
File "openlp\core\lib\mediamanageritem.py", line 661, in build_service_item
File "openlp\plugins\songs\lib\mediaitem.py", line 638, in generate_slide_data
File "openlp\core\ui\media\mediacontroller.py", line 390, in media_length
File "pathlib.py", line 1044, in open
OSError: [Errno 22] Invalid argument: '{"parts": ["C:\", "Users", "Edward", "OneDrive", "PortableApps", "OpenLP", "Data", "songs", "audio", "58", "Rom 6-23.mp3"], "json_meta": {"class": "Path", "version": 1}}'

echan101

There's already a bug report for this, I have added some extra information about it, since really OpenLP should just ignore the missing file so we can fix it manually.
https://gitlab.com/openlp/openlp/-/issues/1368

witterholt

@echan101, thanks for reporting. I've made a merge request to solve this issue.
It will display below error message instead of crashing so that the issue with the missing audio file can be corrected manually.

The fix should be easy as well because I made a fix of saving a song with a non-existent audio file; instead of crashing, as is currently the case, it simply will unlink the non-existent audio file.

echan101

witterholt Wow thanks so much for the quick fix! Really appreciated!!

witterholt

echan101 thanks, I expect it will be included in the next release. I don't know when it will be released though.

PaulRowell

I ended up deleting the rows from the media_files table so that I could use all the songs. But having this fix will be even better!